Is this an OK letter, I'm at my wits end.?

If you tell them not to they can't print the photos. You could even have your school photo removed from the yearbook. The letter seems fine but I would add the request that no picture of you is to be used. Send a copy to the principal and each member of the school board as well (so she can't claim she didn't get the letter.